chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java - Issue 2431373003: [NTP Client][M55] Make status cards non dismissable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

Issue 2431373003: [NTP Client][M55] Make status cards non dismissable (Closed)

Patch Set: make the signin promo dismissable Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

index cdb994e0012f84266d205e731d2a1c98f75477b7..9575bbbf33662d97822e7d6a69d3edfad7efad86 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

@@ -144,5 +144,10 @@ public void updateLayoutParams() {

getParams().topMargin = 0;

}

+ @Override

+ public boolean isDismissable() {

+ return true;

+ }

}