Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2431223009: [DevTools] paint worklet should report context destroyed (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
ikilpatrick, dgozman
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] paint worklet should report context destroyed If someone reports context to inspector with contextCreated, then this context should be reported as destroyed. BUG=chromium:657450, chromium:656626 R=ikilpatrick@chromium.org, dgozman@chromium.org Committed: https://crrev.com/f898cd59b863b70e80d76c254dd62881d0f27f20 Cr-Commit-Position: refs/heads/master@{#426893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, --1 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/worklet/worklet-should-report-context-destroyed.html View 1 chunk +31 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/worklet/worklet-should-report-context-destroyed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kozy
please take a look.
4 years, 2 months ago (2016-10-21 18:22:57 UTC) #2
ikilpatrick
lgtm
4 years, 2 months ago (2016-10-21 18:33:55 UTC) #3
dgozman
lgtm
4 years, 2 months ago (2016-10-21 19:00:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431223009/1
4 years, 2 months ago (2016-10-21 19:03:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 21:38:06 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 21:40:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f898cd59b863b70e80d76c254dd62881d0f27f20
Cr-Commit-Position: refs/heads/master@{#426893}

Powered by Google App Engine
This is Rietveld 408576698