third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp - Issue 2431223009: [DevTools] paint worklet should report context destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

Issue 2431223009: [DevTools] paint worklet should report context destroyed (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/worklet/worklet-should-report-context-destroyed-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

index 9f47410b2adcb6711dd95f61bccec20531cda33f..e8b53dbc12661dec5cd34064fa434c41dba2baa9 100644

--- a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

@@ -47,6 +47,8 @@ PaintWorkletGlobalScope::PaintWorkletGlobalScope(

PaintWorkletGlobalScope::~PaintWorkletGlobalScope() {}

void PaintWorkletGlobalScope::dispose() {

+ MainThreadDebugger::instance()->contextWillBeDestroyed(

+ scriptController()->getScriptState());

// Explicitly clear the paint defininitions to break a reference cycle

// between them and this global scope.

m_paintDefinitions.clear();

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/worklet/worklet-should-report-context-destroyed-expected.txt ('k') | no next file » | no next file with comments »