MediaValuesInitialViewport passed to MediaQueryEvaluator as bool.

MediaValuesInitialViewport passed to MediaQueryEvaluator as bool.

The test coverage for [1] was not good enough. We tried to pass a
MediaValues pointer into the MediaQueryEvaluator constructor, but since
none of the constructors took such a type, it was converted into a bool
for which there was a constructor.

I'm planning to change the bool parameter to an enum in a follow-up CL
to avoid such mistakes in the future.

[1] https://codereview.chromium.org/2414343002/

R=timloh@chromium.org
BUG=332763
Committed: https://crrev.com/ecc4112fc59bb43d04670afae1b439ebc8e9f2e4
Cr-Commit-Position: refs/heads/master@{#426747}

[rune, 2016-10-19 13:36:30]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 13:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 14:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 14:59:35]

Dry run: This issue passed the CQ dry run.

[rune, 2016-10-20 08:01:24]

ptal

[rune, 2016-10-20 11:07:21]

rune@opera.com changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2016-10-21 02:10:52]

lgtm

[rune, 2016-10-21 05:37:14]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-10-21 05:37:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 07:20:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:28:03]

Description was changed from

==========
MediaValuesInitialViewport passed to MediaQueryEvaluator as bool.

The test coverage for [1] was not good enough. We tried to pass a
MediaValues pointer into the MediaQueryEvaluator constructor, but since
none of the constructors took such a type, it was converted into a bool
for which there was a constructor.

I'm planning to change the bool parameter to an enum in a follow-up CL
to avoid such mistakes in the future.

[1] https://codereview.chromium.org/2414343002/

R=timloh@chromium.org
BUG=332763
==========

to

==========
MediaValuesInitialViewport passed to MediaQueryEvaluator as bool.

The test coverage for [1] was not good enough. We tried to pass a
MediaValues pointer into the MediaQueryEvaluator constructor, but since
none of the constructors took such a type, it was converted into a bool
for which there was a constructor.

I'm planning to change the bool parameter to an enum in a follow-up CL
to avoid such mistakes in the future.

[1] https://codereview.chromium.org/2414343002/

R=timloh@chromium.org
BUG=332763

Committed: https://crrev.com/ecc4112fc59bb43d04670afae1b439ebc8e9f2e4
Cr-Commit-Position: refs/heads/master@{#426747}
==========

[commit-bot: I haz the power, 2016-10-21 13:28:04]

Patchset 1 (id:??) landed as
https://crrev.com/ecc4112fc59bb43d04670afae1b439ebc8e9f2e4
Cr-Commit-Position: refs/heads/master@{#426747}