|
Collect @viewport before constructing RuleSets.
- Move ViewportStyleResolver to StyleEngine.
- Only create a ViewportStyleResolver for top level documents.
- Collect @viewport rules via the DocumentStyleSheetCollection.
- Use the initial viewport size for resolving viewport relative
lengths.
- Introduce initialViewportChanged() and viewportRulesChanged() in
StyleEngine to trigger re-collection and resolution of the actual
viewport. These currently trigger an immediate call to updateViewport
which will later be a part of the document lifecycle phase for
updating active stylesheets.
This finally fixes issues 332763, 455136, and 463098.
R=timloh@chromium.org
BUG= 567021, 463098, 455136, 332763
Committed: https://crrev.com/70d21a8093c3096a01fa62e6ac7c7bdba3aeca17
Cr-Commit-Position: refs/heads/master@{#426427}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+126 lines, -89 lines) |
Patch |
|
M |
third_party/WebKit/Source/core/css/RuleSet.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/css/RuleSet.cpp
|
View
|
|
4 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
|
View
|
|
2 chunks |
+0 lines, -11 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/css/resolver/StyleResolver.h
|
View
|
|
3 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
|
View
|
|
5 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.h
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
|
View
|
|
4 chunks |
+7 lines, -26 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/dom/StyleEngine.h
|
View
|
|
4 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/dom/StyleEngine.cpp
|
View
|
|
6 chunks |
+36 lines, -6 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/frame/FrameView.cpp
|
View
|
1
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/page/Page.cpp
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/tests/WebFrameTest.cpp
|
View
|
|
2 chunks |
+49 lines, -4 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/Source/web/tests/data/viewport-and-media.html
|
View
|
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/Source/web/tests/data/viewport-lengths.html
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
Depends on Patchset:
Dependent Patchsets:
Total messages: 16 (11 generated)
|