Issue 243013006: events: Move the PlatformEventSource creation in aura::Env.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243013006: events: Move the PlatformEventSource creation in aura::Env. (Closed)

Created:
6 years, 8 months ago by sadrul

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+aura_chromium.org, kalyank

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

events: Move the PlatformEventSource creation in aura::Env. Instead of creating the event-source in WMState, or in WMTestHelper, create the event-source in aura::Env, and have Env own the event-source. BUG=354062 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265005

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -14 lines)			Patch
M	ui/aura/env.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/aura/env.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/wm/core/wm_state.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/wm/core/wm_state.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/wm/test/wm_test_helper.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/wm/test/wm_test_helper.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

sadrul

I think this makes more sense, since Env also has the responsibility of initializing the ...

6 years, 8 months ago (2014-04-19 19:07:03 UTC) #1

sadrul

6 years, 8 months ago (2014-04-21 16:19:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r265005 (presubmit successful).