Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 2429353002: Remove stale comment regarding StringKeyframe being eagerly evaluated. (Closed)

Created:
4 years, 2 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
Reviewers:
loyso (OOO)
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans, dstockwell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stale comment regarding StringKeyframe being eagerly evaluated. As of https://codereview.chromium.org/2043273002 we don't snapshot compositor keyframes eagerly, instead we snapshot during style resolve. The compositor animations code relies on style resolve occuring before we commit compositor animations rather than eager evaluation now. BUG=657242 Committed: https://crrev.com/f4ffc982b16ade07e7b821633110807cc325d272 Cr-Commit-Position: refs/heads/master@{#426376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alancutter (OOO until 2018)
4 years, 2 months ago (2016-10-19 04:40:32 UTC) #2
loyso (OOO)
LGTM
4 years, 2 months ago (2016-10-19 05:31:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429353002/1
4 years, 2 months ago (2016-10-19 05:35:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/298927)
4 years, 2 months ago (2016-10-19 12:37:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429353002/1
4 years, 2 months ago (2016-10-20 00:20:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 02:37:02 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:14:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4ffc982b16ade07e7b821633110807cc325d272
Cr-Commit-Position: refs/heads/master@{#426376}

Powered by Google App Engine
This is Rietveld 408576698