Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

Issue 2429353002: Remove stale comment regarding StringKeyframe being eagerly evaluated. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
index 745fd620199c57ab0c31cec2bb904454bd76217c..27d47d07a2aed0353a0f1ebf334a6bc1e46cab6f 100644
--- a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
@@ -527,11 +527,7 @@ void addKeyframesToCurve(
else
keyframeTimingFunction = &keyframe->easing();
- // FIXME: This relies on StringKeyframes being eagerly evaluated, which will
- // not happen eventually. Instead we should extract the CSSValue here
- // and convert using another set of toAnimatableXXXOperations functions.
const AnimatableValue* value = keyframe->getAnimatableValue().get();
-
addKeyframeToCurve(curve, keyframe.get(), value, *keyframeTimingFunction);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698