Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2429223003: Add --html --json args to valueset2html. (Closed)

Created:
4 years, 2 months ago by benjhayden
Modified:
4 years, 2 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add --html --json args to valueset2html. Currently, valueset2html only upgrades a results2.html in-place. This change adds support for merging results from multiple html or json files into a results2.html. BUG=catapult:#2945 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6962f5c0344a79b152bf84460a93e1b2e11ea0f4

Patch Set 1 #

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M tracing/bin/valueset2html View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL :-)
4 years, 2 months ago (2016-10-19 19:10:03 UTC) #3
eakuefner
lgtm
4 years, 2 months ago (2016-10-21 21:22:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429223003/20001
4 years, 2 months ago (2016-10-22 03:21:00 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 03:44:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698