chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc - Issue 2429173005: Mus+Ash: Replace (Server)WindowSurface with (Server)WindowCompositorFrameSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

Issue 2429173005: Mus+Ash: Replace (Server)WindowSurface with (Server)WindowCompositorFrameSink (Closed)

Patch Set: Rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

index 07932f9c280bbba96935e481e1724825ac584861..17836ac94f71e28f26a6cc634905f4b1023a81cc 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

@@ -242,7 +242,7 @@ void ImmersiveModeControllerAsh::CreateMashRevealWidget() {

mash_reveal_widget_.get(),

views::WindowManagerConnection::Get()->client()->NewWindow(

&window_properties),

- ui::mojom::SurfaceType::DEFAULT);

+ ui::mojom::CompositorFrameSinkType::DEFAULT);

init_params.accept_events = false;

init_params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

init_params.activatable = views::Widget::InitParams::ACTIVATABLE_NO;