Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2429173005: Mus+Ash: Replace (Server)WindowSurface with (Server)WindowCompositorFrameSink (Closed)

Created:
4 years, 2 months ago by Fady Samuel
Modified:
4 years, 1 month ago
Reviewers:
rjkroege, jam, sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, abarth-chromium, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus+Ash: Replace (Server)WindowSurface with (Server)WindowCompositorFrameSink In an effort to unify Mus+Ash and Chrome terminology, this CL replaces all WindowSurface references with ui::(Server)WindowCompositorFrameSink. This CL is a followup to https://codereview.chromium.org/2430653002/ BUG=656975 TBR=tsepez@chromium.org for renaming of methods in mojoms. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/d892195197edfcb956c6bd5c65f72763d79c588f Cr-Commit-Position: refs/heads/master@{#426984}

Patch Set 1 #

Patch Set 2 : Kill WindowSurface #

Patch Set 3 : ui::CompositorFrameSink => ui::WindowCompositorFrameSink #

Total comments: 12

Patch Set 4 : Addressed rjkroege and jam's comments #

Patch Set 5 : Rebase #

Patch Set 6 : Fix native_widget_mus_unittest #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+743 lines, -1055 lines) Patch
M ash/autoclick/mus/autoclick_application.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/frame/detached_title_area_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/native_widget_factory_mus.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/mus/non_client_frame_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/OWNERS View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 1 2 4 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/mus/OWNERS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 1 4 3 chunks +8 lines, -5 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 4 3 chunks +14 lines, -9 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 2 4 3 chunks +11 lines, -9 lines 0 comments Download
M mash/login/login.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/view_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M services/ui/demo/bitmap_uploader.h View 1 2 3 4 5 6 2 chunks +4 lines, -5 lines 0 comments Download
M services/ui/demo/bitmap_uploader.cc View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 1 2 3 4 5 6 4 chunks +2 lines, -5 lines 0 comments Download
D services/ui/public/cpp/compositor_frame_sink.h View 1 2 4 1 chunk +0 lines, -48 lines 0 comments Download
D services/ui/public/cpp/compositor_frame_sink.cc View 1 2 4 1 chunk +0 lines, -60 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.h View 4 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.cc View 4 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/window.h View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
M services/ui/public/cpp/window.cc View 1 2 4 2 chunks +18 lines, -15 lines 0 comments Download
A services/ui/public/cpp/window_compositor_frame_sink.h View 1 2 3 1 chunk +94 lines, -0 lines 0 comments Download
A services/ui/public/cpp/window_compositor_frame_sink.cc View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
D services/ui/public/cpp/window_surface.h View 1 4 1 chunk +0 lines, -93 lines 0 comments Download
D services/ui/public/cpp/window_surface.cc View 1 4 1 chunk +0 lines, -79 lines 0 comments Download
D services/ui/public/cpp/window_surface_client.h View 1 4 1 chunk +0 lines, -29 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 1 2 3 4 1 chunk +5 lines, -4 lines 0 comments Download
M services/ui/public/interfaces/window_tree.mojom View 1 4 1 chunk +6 lines, -6 lines 0 comments Download
M services/ui/public/interfaces/window_tree_constants.mojom View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/ws/BUILD.gn View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M services/ui/ws/access_policy.h View 1 chunk +3 lines, -2 lines 0 comments Download
M services/ui/ws/cursor_unittest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M services/ui/ws/default_access_policy.h View 1 chunk +3 lines, -2 lines 0 comments Download
M services/ui/ws/default_access_policy.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/ws/event_dispatcher_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/frame_generator.h View 1 2 3 4 2 chunks +9 lines, -8 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 2 3 4 7 chunks +34 lines, -27 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 1 2 3 4 3 chunks +10 lines, -9 lines 0 comments Download
M services/ui/ws/server_window.h View 4 5 chunks +14 lines, -11 lines 0 comments Download
M services/ui/ws/server_window.cc View 4 3 chunks +12 lines, -10 lines 0 comments Download
A + services/ui/ws/server_window_compositor_frame_sink.h View 4 6 chunks +19 lines, -17 lines 0 comments Download
A + services/ui/ws/server_window_compositor_frame_sink.cc View 4 3 chunks +23 lines, -17 lines 0 comments Download
A + services/ui/ws/server_window_compositor_frame_sink_manager.h View 4 2 chunks +26 lines, -23 lines 0 comments Download
A services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +102 lines, -0 lines 0 comments Download
A services/ui/ws/server_window_compositor_frame_sink_manager_test_api.h View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A services/ui/ws/server_window_compositor_frame_sink_manager_test_api.cc View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
D services/ui/ws/server_window_surface.h View 4 1 chunk +0 lines, -105 lines 0 comments Download
D services/ui/ws/server_window_surface.cc View 4 1 chunk +0 lines, -103 lines 0 comments Download
D services/ui/ws/server_window_surface_manager.h View 4 1 chunk +0 lines, -79 lines 0 comments Download
D services/ui/ws/server_window_surface_manager.cc View 4 1 chunk +0 lines, -91 lines 0 comments Download
D services/ui/ws/server_window_surface_manager_test_api.h View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
D services/ui/ws/server_window_surface_manager_test_api.cc View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_finder.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M services/ui/ws/window_finder_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/window_manager_access_policy.h View 1 chunk +4 lines, -2 lines 0 comments Download
M services/ui/ws/window_manager_access_policy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/ws/window_manager_state_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_server.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_server.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M services/ui/ws/window_server_test_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 2 3 4 3 chunks +12 lines, -10 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 2 3 4 chunks +10 lines, -6 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 5 6 1 chunk +5 lines, -4 lines 0 comments Download
M ui/views/mus/native_widget_mus_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 2 4 2 chunks +6 lines, -4 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 35 (19 generated)
Fady Samuel
4 years, 2 months ago (2016-10-20 01:09:13 UTC) #3
rjkroege
lgtm with nits. Please make sure to file bugs and add the TODOs (with bugs.) ...
4 years, 2 months ago (2016-10-20 22:22:18 UTC) #4
Fady Samuel
+sky@ I still need to address Rob's nits, but passing to OWNER in parallel.
4 years, 2 months ago (2016-10-21 00:04:18 UTC) #6
Fady Samuel
+jam@ for content + chrome misc changes
4 years, 2 months ago (2016-10-21 00:04:42 UTC) #8
sky
LGTM
4 years, 2 months ago (2016-10-21 03:26:37 UTC) #9
jam
lgtm with one change: add the folks working on mus to content/renderer/mus/owners and make per-file ...
4 years, 1 month ago (2016-10-21 15:59:54 UTC) #10
Fady Samuel
CQ'ing. Thanks all! https://codereview.chromium.org/2429173005/diff/40001/ash/autoclick/mus/autoclick_application.cc File ash/autoclick/mus/autoclick_application.cc (right): https://codereview.chromium.org/2429173005/diff/40001/ash/autoclick/mus/autoclick_application.cc#newcode116 ash/autoclick/mus/autoclick_application.cc:116: widget_.get(), window, ui::mojom::CompositorFrameSinkType::DEFAULT); On 2016/10/20 22:22:18, ...
4 years, 1 month ago (2016-10-21 20:53:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429173005/60001
4 years, 1 month ago (2016-10-21 20:54:07 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/291651) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-10-21 20:57:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429173005/80001
4 years, 1 month ago (2016-10-21 21:31:11 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/108125)
4 years, 1 month ago (2016-10-21 22:18:00 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429173005/100001
4 years, 1 month ago (2016-10-22 00:56:52 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/300949)
4 years, 1 month ago (2016-10-22 01:43:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429173005/120001
4 years, 1 month ago (2016-10-22 03:17:04 UTC) #31
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 1 month ago (2016-10-22 06:27:11 UTC) #33
commit-bot: I haz the power
4 years, 1 month ago (2016-10-22 06:32:43 UTC) #35
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d892195197edfcb956c6bd5c65f72763d79c588f
Cr-Commit-Position: refs/heads/master@{#426984}

Powered by Google App Engine
This is Rietveld 408576698