third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 2429113002: Don't update height in LayoutBlock::markFixedPositionObjectForLayoutIfNeeded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2429113002: Don't update height in LayoutBlock::markFixedPositionObjectForLayoutIfNeeded. (Closed)

Patch Set: address review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index ed087e6f277f87db0e4e01b6940e59f6aafaa062..fe2e00d0193505c3fea8e92e25ff97770ac3483d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -887,6 +887,7 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {

virtual void updateLogicalWidth();

void updateLogicalHeight();

+ void computeLogicalHeight(LogicalExtentComputedValues&) const;

virtual void computeLogicalHeight(LayoutUnit logicalHeight,

LayoutUnit logicalTop,

LogicalExtentComputedValues&) const;