Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2429113002: Don't update height in LayoutBlock::markFixedPositionObjectForLayoutIfNeeded. (Closed)
Patch Set: address review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 869 matching lines...) Expand 10 before | Expand all | Expand 10 after
880 880
881 LayoutUnit containingBlockLogicalWidthForContent() const override; 881 LayoutUnit containingBlockLogicalWidthForContent() const override;
882 LayoutUnit containingBlockLogicalHeightForContent( 882 LayoutUnit containingBlockLogicalHeightForContent(
883 AvailableLogicalHeightType) const; 883 AvailableLogicalHeightType) const;
884 884
885 LayoutUnit containingBlockAvailableLineWidth() const; 885 LayoutUnit containingBlockAvailableLineWidth() const;
886 LayoutUnit perpendicularContainingBlockLogicalHeight() const; 886 LayoutUnit perpendicularContainingBlockLogicalHeight() const;
887 887
888 virtual void updateLogicalWidth(); 888 virtual void updateLogicalWidth();
889 void updateLogicalHeight(); 889 void updateLogicalHeight();
890 void computeLogicalHeight(LogicalExtentComputedValues&) const;
890 virtual void computeLogicalHeight(LayoutUnit logicalHeight, 891 virtual void computeLogicalHeight(LayoutUnit logicalHeight,
891 LayoutUnit logicalTop, 892 LayoutUnit logicalTop,
892 LogicalExtentComputedValues&) const; 893 LogicalExtentComputedValues&) const;
893 // This function will compute the logical border-box height, without laying 894 // This function will compute the logical border-box height, without laying
894 // out the box. This means that the result is only "correct" when the height 895 // out the box. This means that the result is only "correct" when the height
895 // is explicitly specified. This function exists so that intrinsic width 896 // is explicitly specified. This function exists so that intrinsic width
896 // calculations have a way to deal with children that have orthogonal flows. 897 // calculations have a way to deal with children that have orthogonal flows.
897 // When there is no explicit height, this function assumes a content height of 898 // When there is no explicit height, this function assumes a content height of
898 // zero (and returns just border+padding). 899 // zero (and returns just border+padding).
899 LayoutUnit computeLogicalHeightWithoutLayout() const; 900 LayoutUnit computeLogicalHeightWithoutLayout() const;
(...skipping 721 matching lines...) Expand 10 before | Expand all | Expand 10 after
1621 1622
1622 inline bool LayoutBox::isForcedFragmentainerBreakValue(EBreak breakValue) { 1623 inline bool LayoutBox::isForcedFragmentainerBreakValue(EBreak breakValue) {
1623 return breakValue == BreakColumn || breakValue == BreakLeft || 1624 return breakValue == BreakColumn || breakValue == BreakLeft ||
1624 breakValue == BreakPage || breakValue == BreakRecto || 1625 breakValue == BreakPage || breakValue == BreakRecto ||
1625 breakValue == BreakRight || breakValue == BreakVerso; 1626 breakValue == BreakRight || breakValue == BreakVerso;
1626 } 1627 }
1627 1628
1628 } // namespace blink 1629 } // namespace blink
1629 1630
1630 #endif // LayoutBox_h 1631 #endif // LayoutBox_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698