third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp - Issue 2428363004: Get rid of createVisibleSelection() taking PositionWithAffinity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2428363004: Get rid of createVisibleSelection() taking PositionWithAffinity (Closed)

Patch Set: 2016-10-20T14:00:21 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

index 614c5e41e54ebe66c43bb556d17e99d9629bd892..ba01e67f13348ca5b094c2c8ae6ac54b126f1bda 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

@@ -425,7 +425,9 @@ TEST_F(VisibleSelectionTest, updateIfNeededWithShadowHost) {

// Simulates saving selection in undo stack.

VisibleSelection selection =

- createVisibleSelection(Position(sample->firstChild(), 0));

+ createVisibleSelection(SelectionInDOMTree::Builder()

+ .collapse(Position(sample->firstChild(), 0))

+ .build());

EXPECT_EQ(Position(sample->firstChild(), 0), selection.start());

// Simulates modifying DOM tree to invalidate distribution.