Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2675)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2428363004: Get rid of createVisibleSelection() taking PositionWithAffinity (Closed)
Patch Set: 2016-10-20T14:00:21 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index fb3069fe61f76e94f0d4211defb816f5f0074449..f4d1febaa0e717e80e7e301e1cd244da75613e28 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -98,11 +98,6 @@ VisibleSelection createVisibleSelection(const Position& base,
return createVisibleSelection(builder.build());
}
-VisibleSelection createVisibleSelection(const PositionWithAffinity& pos,
- bool isDirectional) {
- return createVisibleSelection(pos.position(), pos.affinity(), isDirectional);
-}
-
VisibleSelection createVisibleSelection(const VisiblePosition& base,
const VisiblePosition& extent,
bool isDirectional) {
@@ -833,7 +828,6 @@ void VisibleSelectionTemplate<Strategy>::updateIfNeeded() {
appendTrailingWhitespace();
}
-
template <typename Strategy>
static bool equalSelectionsAlgorithm(
const VisibleSelectionTemplate<Strategy>& selection1,

Powered by Google App Engine
This is Rietveld 408576698