Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2428223003: wptserve: Fix Python process leak on Windows. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
qyearsley, jsbell
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wptserve: Fix Python process leak on Windows. According to a comment in Executive.interrupt(), it doesn't look to work on Windows. We use Executive.kill_process() like apache_http.py does. BUG=623613 NOTRY=true Committed: https://crrev.com/6d4219faf726ee04070450faa8d023d167da6b1f Cr-Commit-Position: refs/heads/master@{#426212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tkent
qyearsley@, jsbell@, would you review this please?
4 years, 2 months ago (2016-10-19 01:29:21 UTC) #2
jsbell
lgtm
4 years, 2 months ago (2016-10-19 15:43:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428223003/1
4 years, 2 months ago (2016-10-19 15:48:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 16:04:57 UTC) #7
qyearsley
lgtm
4 years, 2 months ago (2016-10-19 17:15:48 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:09:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d4219faf726ee04070450faa8d023d167da6b1f
Cr-Commit-Position: refs/heads/master@{#426212}

Powered by Google App Engine
This is Rietveld 408576698