Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Issue 2428223003: wptserve: Fix Python process leak on Windows. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
index aaec90835b40b9aa7d27afefdb29b0f85b81ba18..ad1774fd68fda5979a9a5b5fa8342a88d99c9772 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
@@ -60,7 +60,10 @@ class WPTServe(server_base.ServerBase):
return
# TODO(burnik): Figure out a cleaner way of stopping wptserve.
- self._executive.interrupt(self._pid)
+ if self._platform.is_win():
+ self._executive.kill_process(self._pid)
+ else:
+ self._executive.interrupt(self._pid)
# According to Popen.wait(), this can deadlock when using stdout=PIPE and/or stderr=PIPE.
# We're using DEVNULL for both so that should not occur.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698