Setting "SubSystem" option on "Link" page for Visual Studio project.

Setting "SubSystem" option on "Link" page for Visual Studio project.

When the debugger session in Visual Studio finished, the console window closed
by default. For console applications, such as unit tests, it is possible not to
close the console window immediately. This is controlled by the property
"SubSystem" on "Link" page in project settings. This patch set property
"SubSystem" in generated *.vcxproj file based on the "ldflags" field.

R=brettw@chromium.org
BUG=

Committed: https://crrev.com/2f8e5b9b27201976adb6f5526dad67b386872fbd
Cr-Commit-Position: refs/heads/master@{#426977}

[drbasic, 2016-10-18 14:43:26]

When the debugger session in Visual Studio finished, the console window closed
by default. For console applications, such as unit tests, it is possible not to
close the console window immediately. This is controlled by the property
"SubSystem" on "Link" page in project settings. This patch set property
"SubSystem" in generated *.vcxproj file based on the "ldflags" field.

[drbasic, 2016-10-19 01:16:49]

The CQ bit was checked by drbasic@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 01:33:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 01:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 01:33:48]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brettw, 2016-10-20 18:07:49]

lgtm

https://codereview.chromium.org/2428013002/diff/1/tools/gn/visual_studio_util...
File tools/gn/visual_studio_utils.cc (right):

https://codereview.chromium.org/2428013002/diff/1/tools/gn/visual_studio_util...
tools/gn/visual_studio_utils.cc:135: subsystem, ",", base::TRIM_WHITESPACE,
base::SPLIT_WANT_NONEMPTY);
Need 1 more space indent here :)

[drbasic, 2016-10-22 04:40:03]

The CQ bit was checked by drbasic@yandex-team.ru

[drbasic, 2016-10-22 04:40:03]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2428013002/#ps20001
(title: "Fixed missed space indent")

[commit-bot: I haz the power, 2016-10-22 04:40:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 05:09:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-22 05:13:18]

Description was changed from

==========
Setting "SubSystem" option on "Link" page for Visual Studio project.

When the debugger session in Visual Studio finished, the console window closed
by default. For console applications, such as unit tests, it is possible not to
close the console window immediately. This is controlled by the property
"SubSystem" on "Link" page in project settings. This patch set property
"SubSystem" in generated *.vcxproj file based on the "ldflags" field.

R=brettw@chromium.org
BUG=
==========

to

==========
Setting "SubSystem" option on "Link" page for Visual Studio project.

When the debugger session in Visual Studio finished, the console window closed
by default. For console applications, such as unit tests, it is possible not to
close the console window immediately. This is controlled by the property
"SubSystem" on "Link" page in project settings. This patch set property
"SubSystem" in generated *.vcxproj file based on the "ldflags" field.

R=brettw@chromium.org
BUG=

Committed: https://crrev.com/2f8e5b9b27201976adb6f5526dad67b386872fbd
Cr-Commit-Position: refs/heads/master@{#426977}
==========

[commit-bot: I haz the power, 2016-10-22 05:13:19]

Patchset 2 (id:??) landed as
https://crrev.com/2f8e5b9b27201976adb6f5526dad67b386872fbd
Cr-Commit-Position: refs/heads/master@{#426977}