Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Unified Diff: tools/gn/visual_studio_utils_unittest.cc

Issue 2428013002: Setting "SubSystem" option on "Link" page for Visual Studio project. (Closed)
Patch Set: Fixed missed space indent Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/visual_studio_utils.cc ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_utils_unittest.cc
diff --git a/tools/gn/visual_studio_utils_unittest.cc b/tools/gn/visual_studio_utils_unittest.cc
index c4e253054524dd562231c316187ab3b856c93ed5..261c030536da1cfad5cf21423a47ffeba3cb1f78 100644
--- a/tools/gn/visual_studio_utils_unittest.cc
+++ b/tools/gn/visual_studio_utils_unittest.cc
@@ -92,3 +92,12 @@ TEST(VisualStudioUtils, ParseCompilerOption) {
ParseCompilerOption("/Zc:sizedDealloc", &options);
ASSERT_EQ("/MP /bigobj /Zc:sizedDealloc ", options.additional_options);
}
+
+TEST(VisualStudioUtils, ParseLinkerOption) {
+ LinkerOptions options;
+ ParseLinkerOption("/SUBSYSTEM:CONSOLE,5.02h", &options);
+ ASSERT_EQ("CONSOLE", options.subsystem);
+
+ ParseLinkerOption("/SUBSYSTEM:WINDOWS", &options);
+ ASSERT_EQ("WINDOWS", options.subsystem);
+}
« no previous file with comments | « tools/gn/visual_studio_utils.cc ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698