Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 2427893003: Fix wrong cast in ExtensionsGuestViewContainer. (Closed)
Patch Set: update deps Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.cc
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.cc b/extensions/renderer/guest_view/extensions_guest_view_container.cc
index 575aee75c173e58336f651d3b4f5e08b0418a70d..54d2ea83d63a361c613b815ff5b2ffd5cdca572a 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.cc
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.cc
@@ -4,19 +4,11 @@
#include "extensions/renderer/guest_view/extensions_guest_view_container.h"
-#include "base/location.h"
-#include "base/single_thread_task_runner.h"
-#include "base/threading/thread_task_runner_handle.h"
-#include "content/public/renderer/render_frame.h"
-#include "ui/gfx/geometry/size.h"
-
namespace extensions {
ExtensionsGuestViewContainer::ExtensionsGuestViewContainer(
content::RenderFrame* render_frame)
- : GuestViewContainer(render_frame),
- element_resize_isolate_(nullptr),
- weak_ptr_factory_(this) {
+ : GuestViewContainer(render_frame) {
}
ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
@@ -25,43 +17,4 @@ ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
void ExtensionsGuestViewContainer::OnDestroy(bool embedder_frame_destroyed) {
}
-void ExtensionsGuestViewContainer::RegisterElementResizeCallback(
- v8::Local<v8::Function> callback,
- v8::Isolate* isolate) {
- element_resize_callback_.Reset(isolate, callback);
- element_resize_isolate_ = isolate;
-}
-
-void ExtensionsGuestViewContainer::DidResizeElement(const gfx::Size& new_size) {
- // Call the element resize callback, if one is registered.
- if (element_resize_callback_.IsEmpty())
- return;
-
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(&ExtensionsGuestViewContainer::CallElementResizeCallback,
- weak_ptr_factory_.GetWeakPtr(), new_size));
-}
-
-void ExtensionsGuestViewContainer::CallElementResizeCallback(
- const gfx::Size& new_size) {
- v8::HandleScope handle_scope(element_resize_isolate_);
- v8::Local<v8::Function> callback = v8::Local<v8::Function>::New(
- element_resize_isolate_, element_resize_callback_);
- v8::Local<v8::Context> context = callback->CreationContext();
- if (context.IsEmpty())
- return;
-
- const int argc = 2;
- v8::Local<v8::Value> argv[argc] = {
- v8::Integer::New(element_resize_isolate_, new_size.width()),
- v8::Integer::New(element_resize_isolate_, new_size.height())};
-
- v8::Context::Scope context_scope(context);
- v8::MicrotasksScope microtasks(
- element_resize_isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);
-
- callback->Call(context->Global(), argc, argv);
-}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698