Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: google_apis/gcm/engine/connection_handler_impl.cc

Issue 2427633005: Improve GCM enum switch type safety (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/checkin_request.cc ('k') | google_apis/gcm/engine/mcs_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/connection_handler_impl.cc
diff --git a/google_apis/gcm/engine/connection_handler_impl.cc b/google_apis/gcm/engine/connection_handler_impl.cc
index 38b2ee4fbe28545f814b5d65ca2a82b6b958359b..d2c071ade815c467e300614649b29fdbfeb885dd 100644
--- a/google_apis/gcm/engine/connection_handler_impl.cc
+++ b/google_apis/gcm/engine/connection_handler_impl.cc
@@ -229,8 +229,6 @@ void ConnectionHandlerImpl::WaitForData(ProcessingState state) {
max_bytes_needed = bytes_left;
}
break;
- default:
- NOTREACHED();
}
DCHECK_GE(max_bytes_needed, min_bytes_needed);
@@ -285,8 +283,6 @@ void ConnectionHandlerImpl::WaitForData(ProcessingState state) {
case MCS_PROTO_BYTES:
OnGotMessageBytes();
break;
- default:
- NOTREACHED();
}
}
« no previous file with comments | « google_apis/gcm/engine/checkin_request.cc ('k') | google_apis/gcm/engine/mcs_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698