extensions/renderer/display_source_custom_bindings.cc - Issue 2426393003: [Extensions] Convert some callers of ModuleSystem::CallModuleMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/display_source_custom_bindings.cc

Issue 2426393003: [Extensions] Convert some callers of ModuleSystem::CallModuleMethod (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/display_source_custom_bindings.cc

diff --git a/extensions/renderer/display_source_custom_bindings.cc b/extensions/renderer/display_source_custom_bindings.cc

index c2772ebb0268c85471c3056fc2813615bb9da846..73f0c122eccd41dae48661915f2bec25836c85be 100644

--- a/extensions/renderer/display_source_custom_bindings.cc

+++ b/extensions/renderer/display_source_custom_bindings.cc

@@ -232,8 +232,8 @@ void DisplaySourceCustomBindings::OnCallCompleted(

else

callback_args[1] = v8::String::NewFromUtf8(isolate, error_message.c_str());

- module_system->CallModuleMethod("displaySource", "callCompletionCallback", 2,

- callback_args);

+ module_system->CallModuleMethodSafe("displaySource", "callCompletionCallback",

+ 2, callback_args);

}

void DisplaySourceCustomBindings::OnSessionStarted(