Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6242)

Unified Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 2426393003: [Extensions] Convert some callers of ModuleSystem::CallModuleMethod (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/app_bindings.cc ('k') | extensions/renderer/display_source_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/webstore_bindings.cc
diff --git a/chrome/renderer/extensions/webstore_bindings.cc b/chrome/renderer/extensions/webstore_bindings.cc
index 3cdd6de71852e36f615b68f0207ad5143dc4ab4d..df3e7447f761867025d085d114dc34890c90c864 100644
--- a/chrome/renderer/extensions/webstore_bindings.cc
+++ b/chrome/renderer/extensions/webstore_bindings.cc
@@ -214,7 +214,7 @@ void WebstoreBindings::OnInlineWebstoreInstallResponse(
v8::String::NewFromUtf8(
isolate, api::webstore::kInstallResultCodes[static_cast<int>(result)])
};
- context()->module_system()->CallModuleMethod(
+ context()->module_system()->CallModuleMethodSafe(
"webstore", "onInstallResponse", arraysize(argv), argv);
}
@@ -235,7 +235,7 @@ void WebstoreBindings::OnInlineInstallStageChanged(int stage) {
v8::Context::Scope context_scope(context()->v8_context());
v8::Local<v8::Value> argv[] = {
v8::String::NewFromUtf8(isolate, stage_string)};
- context()->module_system()->CallModuleMethod(
+ context()->module_system()->CallModuleMethodSafe(
"webstore", "onInstallStageChanged", arraysize(argv), argv);
}
@@ -245,7 +245,7 @@ void WebstoreBindings::OnInlineInstallDownloadProgress(int percent_downloaded) {
v8::Context::Scope context_scope(context()->v8_context());
v8::Local<v8::Value> argv[] = {
v8::Number::New(isolate, percent_downloaded / 100.0)};
- context()->module_system()->CallModuleMethod(
+ context()->module_system()->CallModuleMethodSafe(
"webstore", "onDownloadProgress", arraysize(argv), argv);
}
« no previous file with comments | « chrome/renderer/extensions/app_bindings.cc ('k') | extensions/renderer/display_source_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698