Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2426393003: [Extensions] Convert some callers of ModuleSystem::CallModuleMethod (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some callers of ModuleSystem::CallModuleMethod ModuleSystem::CallModuleMethod is deprecated (see bug for more info). Convert some callers to use ModuleSystem::CallModuleMethodSafe. BUG=629431 Committed: https://crrev.com/7b26cf7d53e618e91308852f47f6a406f7f86fb5 Cr-Commit-Position: refs/heads/master@{#426595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/renderer/extensions/app_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/display_source_custom_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
lazyboy@, mind taking a look?
4 years, 2 months ago (2016-10-20 16:25:41 UTC) #7
lazyboy
lgtm
4 years, 2 months ago (2016-10-20 17:56:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426393003/1
4 years, 2 months ago (2016-10-20 20:53:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 21:07:20 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:22:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b26cf7d53e618e91308852f47f6a406f7f86fb5
Cr-Commit-Position: refs/heads/master@{#426595}

Powered by Google App Engine
This is Rietveld 408576698