Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 2426183002: MD Settings: Migrate passwords cr-shared-menu to settings-action-menu. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
hcarmona
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Migrate passwords cr-shared-menu to settings-action-menu. BUG=639718 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0da0ebd42a515770b822eddfb1aac3592046ec60 Cr-Commit-Position: refs/heads/master@{#426262}

Patch Set 1 #

Patch Set 2 : Fix compilation #

Total comments: 2

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -50 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js View 1 5 chunks +16 lines, -29 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dpapad
This is similar to the previous autofill_section.html CL.
4 years, 2 months ago (2016-10-18 23:29:50 UTC) #5
dpapad
On 2016/10/18 at 23:29:50, dpapad wrote: > This is similar to the previous autofill_section.html CL. ...
4 years, 2 months ago (2016-10-19 00:23:02 UTC) #8
hcarmona
lgtm https://codereview.chromium.org/2426183002/diff/20001/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp File chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp (right): https://codereview.chromium.org/2426183002/diff/20001/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp#newcode53 chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp:53: '<(DEPTH)/ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp:cr_shared_menu', cr_shared_menu is not needed anymore.
4 years, 2 months ago (2016-10-19 15:38:34 UTC) #9
dpapad
https://codereview.chromium.org/2426183002/diff/20001/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp File chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp (right): https://codereview.chromium.org/2426183002/diff/20001/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp#newcode53 chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp:53: '<(DEPTH)/ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp:cr_shared_menu', On 2016/10/19 at 15:38:34, Hector Carmona wrote: > ...
4 years, 2 months ago (2016-10-19 17:18:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426183002/40001
4 years, 2 months ago (2016-10-19 17:18:46 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-19 19:51:00 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:10:49 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0da0ebd42a515770b822eddfb1aac3592046ec60
Cr-Commit-Position: refs/heads/master@{#426262}

Powered by Google App Engine
This is Rietveld 408576698