Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3100)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2426183002: MD Settings: Migrate passwords cr-shared-menu to settings-action-menu. (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index ad630969921e595f3d462602b9685d6bcba85fe8..7bcf81ecd7b2e2163b35c5fd43e846237a771aa4 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -4,10 +4,10 @@
<link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="chrome://resources/cr_elements/cr_scrollable_behavior.html">
-<link rel="import" href="chrome://resources/cr_elements/cr_shared_menu/cr_shared_menu.html">
<link rel="import" href="/passwords_and_forms_page/password_edit_dialog.html">
<link rel="import" href="/passwords_and_forms_page/passwords_shared_css.html">
<link rel="import" href="/prefs/prefs.html">
+<link rel="import" href="/settings_action_menu.html">
<link rel="import" href="/settings_shared_css.html">
<dom-module id="passwords-section">
@@ -42,10 +42,6 @@
.selectable {
-webkit-user-select: text;
}
-
- .menu-item {
- @apply(--settings-actionable);
- }
</style>
<div class="settings-box first two-line">
<settings-checkbox id="autosigninCheckbox"
@@ -101,15 +97,15 @@
$i18n{noPasswordsFound}
</div>
</div>
- <cr-shared-menu id="menu">
- <button id="menuEditPassword" class="list-item menu-item"
+ <dialog is="settings-action-menu" id="menu">
+ <button id="menuEditPassword" class="dropdown-item"
on-tap="onMenuEditPasswordTap_"
hidden$="[[!showPasswords]]">$i18n{passwordViewDetails}</button>
- <button id="menuRemovePassword" class="list-item menu-item"
+ <button id="menuRemovePassword" class="dropdown-item"
on-tap="onMenuRemovePasswordTap_">$i18n{removePassword}</button>
- </cr-shared-menu>
- <template is="dom-if" if="[[activePassword]]" restamp>
- <password-edit-dialog on-close="unstampPasswordEditDialog_"
+ </dialog>
+ <template is="dom-if" if="[[showPasswordEditDialog_]]" restamp>
+ <password-edit-dialog on-close="onPasswordEditDialogClosed_"
item="[[activePassword]]">
</password-edit-dialog>
</template>

Powered by Google App Engine
This is Rietveld 408576698