Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2426173002: fix fuzzers (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix fuzzers Many old pathops-related fuzz failures have built up while the codebase was under a state a flux. Now that the code is stable, address these failures. Most of the CL plumbs the debug global state to downstream routines so that, if the data is not trusted (ala fuzzed) the function can safely exit without asserting. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426173002 Committed: https://skia.googlesource.com/skia/+/a35ab3e6e024d0b548ded26a2e3b8ecd838ead93

Patch Set 1 #

Patch Set 2 : fix boatload of fuzzer failures #

Patch Set 3 : fix initialization for linux #

Patch Set 4 : one more linux fix #

Patch Set 5 : wip; linux compat #

Patch Set 6 : fix more linux warnings #

Patch Set 7 : fix one more #

Patch Set 8 : fix angle ideas #

Patch Set 9 : fix more static data #

Patch Set 10 : fix array size cast #

Patch Set 11 : fix angle test #

Patch Set 12 : fix three way #

Patch Set 13 : fix last linux bug #

Patch Set 14 : fix dm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -279 lines) Patch
M src/pathops/SkAddIntersections.cpp View 1 2 chunks +8 lines, -4 lines 0 comments Download
M src/pathops/SkDConicLineIntersection.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkIntersections.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 11 chunks +22 lines, -13 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsConic.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +12 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsCubic.h View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +12 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +23 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsQuad.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +11 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsRect.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 2 3 4 5 6 7 8 9 10 11 12 16 chunks +35 lines, -19 lines 0 comments Download
M src/pathops/SkPathOpsTSect.cpp View 1 1 chunk +12 lines, -12 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathWriter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathWriter.cpp View 1 1 chunk +7 lines, -4 lines 0 comments Download
M tests/PathOpsAngleIdeas.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 10 chunks +43 lines, -22 lines 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 2 3 4 5 6 7 8 9 10 3 chunks +5 lines, -3 lines 0 comments Download
M tests/PathOpsConicIntersectionTest.cpp View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M tests/PathOpsConicLineIntersectionTest.cpp View 1 2 3 4 5 6 7 8 4 chunks +8 lines, -4 lines 0 comments Download
M tests/PathOpsConicQuadIntersectionTest.cpp View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M tests/PathOpsCubicConicIntersectionTest.cpp View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 2 3 4 18 chunks +67 lines, -55 lines 0 comments Download
M tests/PathOpsCubicIntersectionTestData.h View 1 2 3 4 1 chunk +10 lines, -10 lines 0 comments Download
M tests/PathOpsCubicIntersectionTestData.cpp View 1 2 3 4 8 chunks +8 lines, -8 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionIdeas.cpp View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -3 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 2 3 4 5 6 7 8 4 chunks +10 lines, -4 lines 0 comments Download
M tests/PathOpsCubicQuadIntersectionTest.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +8 lines, -4 lines 0 comments Download
M tests/PathOpsCubicReduceOrderTest.cpp View 1 2 3 4 10 chunks +30 lines, -10 lines 0 comments Download
M tests/PathOpsDCubicTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -2 lines 0 comments Download
M tests/PathOpsDRectTest.cpp View 1 2 3 4 5 4 chunks +8 lines, -4 lines 0 comments Download
M tests/PathOpsLineParametetersTest.cpp View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +36 lines, -15 lines 0 comments Download
M tests/PathOpsQuadIntersectionTestData.h View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M tests/PathOpsQuadIntersectionTestData.cpp View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionTest.cpp View 1 2 3 4 4 chunks +8 lines, -4 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionThreadedTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -1 line 0 comments Download
M tests/PathOpsQuadReduceOrderTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +10 lines, -4 lines 0 comments Download
M tests/PathOpsTestCommon.h View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M tests/PathOpsThreeWayTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +10 lines, -6 lines 0 comments Download
M tests/StrokerTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426173002/20001
4 years, 2 months ago (2016-10-19 16:45:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/2119)
4 years, 2 months ago (2016-10-19 16:47:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426173002/40001
4 years, 2 months ago (2016-10-19 17:04:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/2121)
4 years, 2 months ago (2016-10-19 17:10:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426173002/60001
4 years, 2 months ago (2016-10-19 17:16:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/2122)
4 years, 2 months ago (2016-10-19 17:20:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426173002/230001
4 years, 2 months ago (2016-10-20 14:56:31 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-GN-Trybot/builds/2310)
4 years, 2 months ago (2016-10-20 14:58:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426173002/250001
4 years, 2 months ago (2016-10-20 15:11:23 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 15:32:22 UTC) #22
Message was sent while issue was closed.
Committed patchset #14 (id:250001) as
https://skia.googlesource.com/skia/+/a35ab3e6e024d0b548ded26a2e3b8ecd838ead93

Powered by Google App Engine
This is Rietveld 408576698