Issue 24257014: Ignore CC_LIST when private flag is specified.

Issue 24257014: Ignore CC_LIST when private flag is specified. (Closed)

Created:
7 years, 3 months ago by tyoshino (SeeGerritForStatus)

Modified:
7 years, 2 months ago

Reviewers:
cmp, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Ignore CC_LIST when private flag is specified. This prevents private CLs to be automatically CC-ed to public mailing lists unintentionally. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225925

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -5 lines)			Patch
M	gcl.py	View	1 2 3 4	1 chunk	+11 lines, -1 line	0 comments	Download
M	git_cl.py	View	1 2 3	2 chunks	+19 lines, -2 lines	0 comments	Download
M	tests/git_cl_test.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

iannucci

This is great :) https://codereview.chromium.org/24257014/diff/1/gcl.py File gcl.py (right): https://codereview.chromium.org/24257014/diff/1/gcl.py#newcode887 gcl.py:887: cc_list = "" Could you ...

7 years, 3 months ago (2013-09-24 18:52:54 UTC) #2

tyoshino (SeeGerritForStatus)

https://codereview.chromium.org/24257014/diff/1/gcl.py File gcl.py (right): https://codereview.chromium.org/24257014/diff/1/gcl.py#newcode887 gcl.py:887: cc_list = "" On 2013/09/24 18:52:54, iannucci wrote: > ...

7 years, 3 months ago (2013-09-25 05:10:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/24257014/14001

7 years, 2 months ago (2013-09-30 06:15:25 UTC) #6

Message was sent while issue was closed.

Change committed as 225925

Expand Messages | Collapse Messages