Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: gcl.py

Issue 24257014: Ignore CC_LIST when private flag is specified. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 225130)
+++ gcl.py (working copy)
@@ -878,7 +878,17 @@
watchlist = watchlists.Watchlists(change_info.GetLocalRoot())
watchers = watchlist.GetWatchersForPaths(change_info.GetFileNames())
- cc_list = GetCodeReviewSetting("CC_LIST")
+ # We check this before applying the "PRIVATE" parameter of codereview
+ # settings assuming that the author of the settings file has put
+ # addresses which we can send private CLs to, and so we should ignore
+ # CC_LIST only when --private is specified explicitly on the command
+ # line.
+ if "--private" in upload_arg:
+ Warn("WARNING: CC_LIST is ignored since private flag is specified. "
+ "You need to review and add them manually if necessary.")
+ cc_list = ""
+ else:
+ cc_list = GetCodeReviewSetting("CC_LIST")
if not no_watchlists and watchers:
# Filter out all empty elements and join by ','
cc_list = ','.join(filter(None, [cc_list] + watchers))
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698