Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2425423005: MD Settings: Close action menu when search engine is removed. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
hcarmona
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Close action menu when search engine is removed. BUG=657254, 633898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9 Cr-Commit-Position: refs/heads/master@{#426297}

Patch Set 1 : Update tests. #

Patch Set 2 : Nit #

Total comments: 2

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/search_engines_page_test.js View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
dpapad
4 years, 2 months ago (2016-10-19 18:05:45 UTC) #6
hcarmona
lgtm https://codereview.chromium.org/2425423005/diff/40001/chrome/test/data/webui/settings/search_engines_page_test.js File chrome/test/data/webui/settings/search_engines_page_test.js (right): https://codereview.chromium.org/2425423005/diff/40001/chrome/test/data/webui/settings/search_engines_page_test.js#newcode183 chrome/test/data/webui/settings/search_engines_page_test.js:183: extra space (sorry for nittiest of nits!)
4 years, 2 months ago (2016-10-19 18:10:31 UTC) #7
dpapad
https://codereview.chromium.org/2425423005/diff/40001/chrome/test/data/webui/settings/search_engines_page_test.js File chrome/test/data/webui/settings/search_engines_page_test.js (right): https://codereview.chromium.org/2425423005/diff/40001/chrome/test/data/webui/settings/search_engines_page_test.js#newcode183 chrome/test/data/webui/settings/search_engines_page_test.js:183: On 2016/10/19 at 18:10:31, Hector Carmona wrote: > extra ...
4 years, 2 months ago (2016-10-19 18:53:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425423005/60001
4 years, 2 months ago (2016-10-19 18:55:57 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-19 21:57:43 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:55 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9
Cr-Commit-Position: refs/heads/master@{#426297}

Powered by Google App Engine
This is Rietveld 408576698