Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8565)

Unified Diff: chrome/test/data/webui/settings/search_engines_page_test.js

Issue 2425423005: MD Settings: Close action menu when search engine is removed. (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/search_engines_page_test.js
diff --git a/chrome/test/data/webui/settings/search_engines_page_test.js b/chrome/test/data/webui/settings/search_engines_page_test.js
index 8933f98cb7d9fd0bbe52e57cf4892ca2a2db5f49..ea486d6082dccf1f63b727401308645238086e90 100644
--- a/chrome/test/data/webui/settings/search_engines_page_test.js
+++ b/chrome/test/data/webui/settings/search_engines_page_test.js
@@ -176,12 +176,18 @@ cr.define('settings_search_engines_page', function() {
});
test('Remove_Enabled', function() {
+ // Open action menu.
+ MockInteractions.tap(entry.$$('paper-icon-button'));
+ var menu = entry.$$('dialog[is=settings-action-menu]');
+ assertTrue(menu.open);
+
var deleteButton = entry.$.delete;
assertTrue(!!deleteButton);
assertFalse(deleteButton.hidden);
MockInteractions.tap(deleteButton);
return browserProxy.whenCalled('removeSearchEngine').then(
function(modelIndex) {
+ assertFalse(menu.open);
assertEquals(entry.engine.modelIndex, modelIndex);
});
});
@@ -189,12 +195,15 @@ cr.define('settings_search_engines_page', function() {
test('MakeDefault_Enabled', function() {
// Open action menu.
MockInteractions.tap(entry.$$('paper-icon-button'));
+ var menu = entry.$$('dialog[is=settings-action-menu]');
+ assertTrue(menu.open);
var makeDefaultButton = entry.$.makeDefault;
assertTrue(!!makeDefaultButton);
MockInteractions.tap(makeDefaultButton);
return browserProxy.whenCalled('setDefaultSearchEngine').then(
function(modelIndex) {
+ assertFalse(menu.open);
assertEquals(entry.engine.modelIndex, modelIndex);
});
});
@@ -203,6 +212,8 @@ cr.define('settings_search_engines_page', function() {
test('Edit_Enabled', function() {
// Open action menu.
MockInteractions.tap(entry.$$('paper-icon-button'));
+ var menu = entry.$$('dialog[is=settings-action-menu]');
+ assertTrue(menu.open);
var engine = entry.engine;
var editButton = entry.$.edit;
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698