Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 24253009: Replace GR_MAC_BUILD by SK_BUILD_FOR_MAC. (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents. BUG=None TEST=None, no functional changes. R=bsalomon@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=11457

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : GR_LINUX_BUILD #

Patch Set 4 : GR_ANDROID_BUILD #

Patch Set 5 : GR_IOS_BUILD #

Patch Set 6 : GR_QNX_BUILD #

Patch Set 7 : GR_WIN32_BUILD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -146 lines) Patch
M Makefile.old View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gyp/gpu.gyp View 1 2 3 4 5 6 2 chunks +0 lines, -46 lines 0 comments Download
M include/gpu/GrConfig.h View 1 2 3 4 5 6 3 chunks +2 lines, -90 lines 0 comments Download
M include/gpu/gl/GrGLConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/GrGLConfig_chrome.h View 1 2 3 4 5 6 1 chunk +9 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Will this break Mac? I don't have a Mac to compile&test. Regards,
7 years, 3 months ago (2013-09-21 02:40:00 UTC) #1
bsalomon
On 2013/09/21 02:40:00, tfarina wrote: > Will this break Mac? I don't have a Mac ...
7 years, 2 months ago (2013-09-23 13:01:46 UTC) #2
tfarina
On 2013/09/23 13:01:46, bsalomon wrote: > On 2013/09/21 02:40:00, tfarina wrote: > > Will this ...
7 years, 2 months ago (2013-09-24 01:34:08 UTC) #3
bsalomon
On 2013/09/24 01:34:08, tfarina wrote: > On 2013/09/23 13:01:46, bsalomon wrote: > > On 2013/09/21 ...
7 years, 2 months ago (2013-09-24 13:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/24253009/21002
7 years, 2 months ago (2013-09-24 16:17:25 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 2 months ago (2013-09-25 20:44:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/24253009/21002
7 years, 2 months ago (2013-09-25 20:45:48 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-09-25 20:57:57 UTC) #8
Message was sent while issue was closed.
Change committed as 11457

Powered by Google App Engine
This is Rietveld 408576698