Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24246011: Move form-related 78 files to core/html/forms/. (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch
Visibility:
Public.

Description

Move form-related 78 files to core/html/forms/. They are mainly input type implementations, and some helper classes. We don't move implementation classes for IDLs and element sub-classes. We need to fix many style errors including adding toTextEvent(). BUG=none TEST=none; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158101

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -11243 lines) Patch
M Source/core/core.gypi View 5 chunks +76 lines, -75 lines 0 comments Download
D Source/core/dom/CheckedRadioButtons.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/dom/CheckedRadioButtons.cpp View 1 chunk +0 lines, -268 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/dom/TextEvent.h View 2 chunks +7 lines, -0 lines 0 comments Download
D Source/core/html/BaseButtonInputType.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/html/BaseButtonInputType.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/html/BaseCheckableInputType.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/html/BaseCheckableInputType.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
D Source/core/html/BaseChooserOnlyDateAndTimeInputType.h View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/core/html/BaseChooserOnlyDateAndTimeInputType.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
D Source/core/html/BaseClickableWithKeyInputType.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/html/BaseClickableWithKeyInputType.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
D Source/core/html/BaseDateAndTimeInputType.h View 1 chunk +0 lines, -73 lines 0 comments Download
D Source/core/html/BaseDateAndTimeInputType.cpp View 1 chunk +0 lines, -182 lines 0 comments Download
D Source/core/html/BaseMultipleFieldsDateAndTimeInputType.h View 1 chunk +0 lines, -130 lines 0 comments Download
D Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +0 lines, -604 lines 0 comments Download
D Source/core/html/BaseTextInputType.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/html/BaseTextInputType.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/html/ButtonInputType.h View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/html/ButtonInputType.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/html/CheckboxInputType.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/html/CheckboxInputType.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
D Source/core/html/ColorInputType.h View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/core/html/ColorInputType.cpp View 1 chunk +0 lines, -247 lines 0 comments Download
D Source/core/html/DateInputType.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/html/DateInputType.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
D Source/core/html/DateTimeFieldsState.h View 1 chunk +0 lines, -102 lines 0 comments Download
D Source/core/html/DateTimeFieldsState.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
D Source/core/html/DateTimeLocalInputType.h View 1 chunk +0 lines, -73 lines 0 comments Download
D Source/core/html/DateTimeLocalInputType.cpp View 1 chunk +0 lines, -179 lines 0 comments Download
D Source/core/html/EmailInputType.h View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/html/EmailInputType.cpp View 1 chunk +0 lines, -281 lines 0 comments Download
D Source/core/html/FileInputType.h View 1 chunk +0 lines, -86 lines 0 comments Download
D Source/core/html/FileInputType.cpp View 1 chunk +0 lines, -382 lines 0 comments Download
D Source/core/html/FormController.h View 1 chunk +0 lines, -113 lines 0 comments Download
D Source/core/html/FormController.cpp View 1 chunk +0 lines, -528 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElementWithState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/html/HiddenInputType.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/html/HiddenInputType.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
D Source/core/html/ImageInputType.h View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/core/html/ImageInputType.cpp View 1 chunk +0 lines, -222 lines 0 comments Download
D Source/core/html/InputType.h View 1 chunk +0 lines, -253 lines 0 comments Download
D Source/core/html/InputType.cpp View 1 chunk +0 lines, -999 lines 0 comments Download
D Source/core/html/InputTypeNames.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/html/InputTypeNames.cpp View 1 chunk +0 lines, -172 lines 0 comments Download
D Source/core/html/MonthInputType.h View 1 chunk +0 lines, -73 lines 0 comments Download
D Source/core/html/MonthInputType.cpp View 1 chunk +0 lines, -174 lines 0 comments Download
D Source/core/html/NumberInputType.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/html/NumberInputType.cpp View 1 chunk +0 lines, -307 lines 0 comments Download
D Source/core/html/PasswordInputType.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/html/PasswordInputType.cpp View 1 chunk +0 lines, -145 lines 0 comments Download
D Source/core/html/RadioInputType.h View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/html/RadioInputType.cpp View 1 chunk +0 lines, -193 lines 0 comments Download
D Source/core/html/RangeInputType.h View 1 chunk +0 lines, -82 lines 0 comments Download
D Source/core/html/RangeInputType.cpp View 1 chunk +0 lines, -396 lines 0 comments Download
D Source/core/html/ResetInputType.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/html/ResetInputType.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/core/html/SearchInputType.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/html/SearchInputType.cpp View 1 chunk +0 lines, -184 lines 0 comments Download
D Source/core/html/StepRange.h View 1 chunk +0 lines, -121 lines 0 comments Download
D Source/core/html/StepRange.cpp View 1 chunk +0 lines, -170 lines 0 comments Download
D Source/core/html/SubmitInputType.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/html/SubmitInputType.cpp View 1 chunk +0 lines, -99 lines 0 comments Download
D Source/core/html/TelephoneInputType.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/html/TelephoneInputType.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/html/TextFieldInputType.h View 1 chunk +0 lines, -105 lines 0 comments Download
D Source/core/html/TextFieldInputType.cpp View 1 chunk +0 lines, -491 lines 0 comments Download
D Source/core/html/TextInputType.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/html/TextInputType.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/html/TimeInputType.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/html/TimeInputType.cpp View 1 chunk +0 lines, -179 lines 0 comments Download
D Source/core/html/TypeAhead.h View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/core/html/TypeAhead.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
D Source/core/html/URLInputType.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/html/URLInputType.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/html/ValidationMessage.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/html/ValidationMessage.cpp View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/html/WeekInputType.h View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/core/html/WeekInputType.cpp View 1 chunk +0 lines, -129 lines 0 comments Download
A + Source/core/html/forms/BaseButtonInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseCheckableInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseCheckableInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseClickableWithKeyInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseClickableWithKeyInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseDateAndTimeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseDateAndTimeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 4 chunks +9 lines, -7 lines 0 comments Download
A + Source/core/html/forms/BaseTextInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/BaseTextInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/ButtonInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/ButtonInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/CheckboxInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/CheckboxInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/CheckedRadioButtons.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/html/forms/CheckedRadioButtons.cpp View 5 chunks +9 lines, -8 lines 0 comments Download
A + Source/core/html/forms/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/ColorInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/DateInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/DateInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/html/forms/DateTimeFieldsState.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/html/forms/DateTimeFieldsState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/DateTimeLocalInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/DateTimeLocalInputType.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
A + Source/core/html/forms/EmailInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/EmailInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/FileInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/FileInputType.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/html/forms/FormController.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/FormController.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/html/forms/HiddenInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/HiddenInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/html/forms/ImageInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/ImageInputType.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
A + Source/core/html/forms/InputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/InputType.cpp View 2 chunks +25 lines, -25 lines 0 comments Download
A + Source/core/html/forms/InputTypeNames.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/html/forms/InputTypeNames.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/MonthInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/MonthInputType.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
A + Source/core/html/forms/NumberInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/NumberInputType.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
A + Source/core/html/forms/PasswordInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/PasswordInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/html/forms/RadioInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/RadioInputType.cpp View 4 chunks +10 lines, -9 lines 0 comments Download
A + Source/core/html/forms/RangeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/RangeInputType.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/html/forms/ResetInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/ResetInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/SearchInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/StepRange.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/html/forms/StepRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/SubmitInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/SubmitInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/TelephoneInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/TelephoneInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/TextFieldInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/TextFieldInputType.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
A + Source/core/html/forms/TextInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/TextInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/TimeInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/TimeInputType.cpp View 2 chunks +15 lines, -16 lines 0 comments Download
A + Source/core/html/forms/TypeAhead.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/html/forms/TypeAhead.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
A + Source/core/html/forms/URLInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/URLInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/ValidationMessage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/html/forms/ValidationMessage.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/forms/WeekInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/html/forms/WeekInputType.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeFieldElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeSymbolicFieldElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ExternalDateTimeChooser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebHistoryItem.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
7 years, 3 months ago (2013-09-20 06:04:30 UTC) #1
keishi
lgtm
7 years, 3 months ago (2013-09-20 08:13:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/24246011/7001
7 years, 3 months ago (2013-09-20 08:17:12 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 11:27:20 UTC) #4
Message was sent while issue was closed. 
Change committed as 158101

Powered by Google App Engine
This is Rietveld 408576698