Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2424143002: Elim detached_panel type and update chrome.windows documentation (Closed)

Created:
4 years, 2 months ago by stevenjb
Modified:
4 years, 2 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elim detached_panel type and update chrome.windows documentation This also eliminates references to --enable-panels BUG=467808 For random OWNERS of minor changes: TBR=rdevlin.cronin@chromium.org Committed: https://crrev.com/ca1dd5ae53fc34528cb5cff4086b3ec96ac4c9fb Cr-Commit-Position: refs/heads/master@{#426365}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/windows.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/whats_new.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/windows.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
stevenjb
4 years, 2 months ago (2016-10-17 19:16:08 UTC) #4
stevenjb
Thanks for closing the issue. I was about to do the same but figured I ...
4 years, 2 months ago (2016-10-17 19:16:51 UTC) #5
Dmitry Titov
LGTM Thanks!
4 years, 2 months ago (2016-10-17 20:41:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424143002/20001
4 years, 2 months ago (2016-10-17 20:45:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/282966)
4 years, 2 months ago (2016-10-17 21:11:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424143002/20001
4 years, 2 months ago (2016-10-19 23:41:44 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 01:14:38 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:14:16 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca1dd5ae53fc34528cb5cff4086b3ec96ac4c9fb
Cr-Commit-Position: refs/heads/master@{#426365}

Powered by Google App Engine
This is Rietveld 408576698