Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5189)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2424143002: Elim detached_panel type and update chrome.windows documentation (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index b0bc10e7696ae612ea84446bac640a245717b301..021df4b62ccce2a514dccb11a0e479d8fd8a07f1 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -225,9 +225,7 @@ bool IsValidStateForWindowsCreateFunction(
bool has_bound = create_data->left || create_data->top ||
create_data->width || create_data->height;
- bool is_panel =
- create_data->type == windows::CreateType::CREATE_TYPE_PANEL ||
- create_data->type == windows::CreateType::CREATE_TYPE_DETACHED_PANEL;
+ bool is_panel = create_data->type == windows::CreateType::CREATE_TYPE_PANEL;
switch (create_data->state) {
case windows::WINDOW_STATE_MINIMIZED:
@@ -500,8 +498,7 @@ ExtensionFunction::ResponseAction WindowsCreateFunction::Run() {
extension_id = extension()->id();
break;
- case windows::CREATE_TYPE_PANEL:
- case windows::CREATE_TYPE_DETACHED_PANEL: {
+ case windows::CREATE_TYPE_PANEL: {
extension_id = extension()->id();
#if defined(USE_ASH)
// Only ChromeOS' version of chrome.windows.create would create a panel
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698