Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2424003003: Sync more DMServer proto comments to the client. (Closed)

Created:
4 years, 2 months ago by Thiemo Nagel
Modified:
4 years, 2 months ago
Reviewers:
dkalin1, peletskyi, dkalin
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync more DMServer proto comments to the client. Also replace mentionings of the deprecated platformKeysPrivate by platformKeys. Comments only, no functional changes. BUG=645078 Committed: https://crrev.com/9a1580424d6de98575f9015f3ef3585a12c8d2dc Cr-Commit-Position: refs/heads/master@{#426523}

Patch Set 1 #

Patch Set 2 : Replace platformKeysPrivate by platformKeys. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 chunk +2 lines, -0 lines 2 comments Download
M components/policy/proto/device_management_backend.proto View 2 chunks +19 lines, -16 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Thiemo Nagel
Hi Sasha, could you please take a look? Thank you, Thiemo
4 years, 2 months ago (2016-10-17 18:30:06 UTC) #3
Thiemo Nagel
Hi Dennis, could you please take a look at the platformKeys changes to policy_templates.json? Thank ...
4 years, 2 months ago (2016-10-18 15:21:00 UTC) #8
peletskyi
On 2016/10/18 15:21:00, Thiemo Nagel (slow) wrote: > Hi Dennis, > > could you please ...
4 years, 2 months ago (2016-10-18 17:08:21 UTC) #11
peletskyi
https://codereview.chromium.org/2424003003/diff/20001/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right): https://codereview.chromium.org/2424003003/diff/20001/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto#newcode296 chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:296: // Example of the package name: "com.android.camera". Do not ...
4 years, 2 months ago (2016-10-19 09:29:04 UTC) #12
dkalin
On 2016/10/18 15:21:00, Thiemo Nagel (slow) wrote: > Hi Dennis, > > could you please ...
4 years, 2 months ago (2016-10-20 16:19:14 UTC) #13
dkalin
lgtm https://codereview.chromium.org/2424003003/diff/20001/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right): https://codereview.chromium.org/2424003003/diff/20001/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto#newcode296 chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:296: // Example of the package name: "com.android.camera". Do ...
4 years, 2 months ago (2016-10-20 16:20:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424003003/20001
4 years, 2 months ago (2016-10-20 16:38:33 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 17:46:26 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:19:54 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a1580424d6de98575f9015f3ef3585a12c8d2dc
Cr-Commit-Position: refs/heads/master@{#426523}

Powered by Google App Engine
This is Rietveld 408576698