chrome/browser/chromeos/policy/proto/chrome_device_policy.proto - Issue 2424003003: Sync more DMServer proto comments to the client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

Issue 2424003003: Sync more DMServer proto comments to the client. (Closed)

Patch Set: Replace platformKeysPrivate by platformKeys. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

diff --git a/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto b/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

index 3789e5f13827c62a47ef22d7de6ab578c489d9ad..c513f7debc9015fe1db91befe1aed19f0f41a20e 100644

--- a/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

+++ b/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

@@ -293,6 +293,8 @@ message AndroidKioskAppInfoProto {

// In the event this is the only field that is specified, runtime may use

// PackageManager.getLaunchIntentForPackage() to start the app. See

// https://developer.android.com/reference/android/content/pm/PackageManager.html

+ // Example of the package name: "com.android.camera". Do not include "app:"

peletskyi 2016/10/19 09:29:03 Dennis, what about "app:" prefix? I saw there are

dkalin 2016/10/20 16:20:59 This CL LGTM. App: prefix should not be included.

+ // prefix in the package name.

optional string package_name = 1;

// Class name (optional). If present, class name is to be combined with

« no previous file with comments | « no previous file | components/policy/proto/device_management_backend.proto » ('j') | no next file with comments »