tests/lib/mirrors/is_odd_test.dart - Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/mirrors/is_odd_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge line Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/lib/mirrors/is_odd_test.dart

diff --git a/tests/lib/mirrors/is_odd_test.dart b/tests/lib/mirrors/is_odd_test.dart

index c9fdde151b06f0bff454a2f3bf1e83f8334da9ea..0dc1655c8244dc34f95b505a235174b0fd403dcb 100644

--- a/tests/lib/mirrors/is_odd_test.dart

+++ b/tests/lib/mirrors/is_odd_test.dart

@@ -11,6 +11,6 @@ import 'dart:mirrors';

import 'package:expect/expect.dart';

main() {

- Expect.isTrue(reflect(1).getField(new Symbol('isOdd')).reflectee);

- Expect.isFalse(reflect(2).getField(new Symbol('isOdd')).reflectee);

+ Expect.isTrue(reflect(1).getField(#isOdd).reflectee);

+ Expect.isFalse(reflect(2).getField(#isOdd).reflectee);

}

« no previous file with comments | « tests/lib/mirrors/invoke_throws_test.dart ('k') | tests/lib/mirrors/lazy_static_test.dart » ('j') | no next file with comments »