Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tests/lib/mirrors/redirecting_factory_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/mirrors/redirecting_factory_test.dart
diff --git a/tests/lib/mirrors/redirecting_factory_test.dart b/tests/lib/mirrors/redirecting_factory_test.dart
index 7da01a2a97870eca35aa43b8e3c91f7dc52b0c37..1d0059faf28026e28d871a6ca0f866d2bd2ec04e 100644
--- a/tests/lib/mirrors/redirecting_factory_test.dart
+++ b/tests/lib/mirrors/redirecting_factory_test.dart
@@ -60,25 +60,25 @@ main() {
Expect.equals(2, instanceMirror.reflectee.field);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryNoOptional'), [8, 6]);
+ #redirectingFactoryNoOptional, [8, 6]);
Expect.equals(2, instanceMirror.reflectee.field);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryUnnamedOptional'), [43, 1]);
+ #redirectingFactoryUnnamedOptional, [43, 1]);
Expect.equals(42, instanceMirror.reflectee.field);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryMoreUnnamedOptional'), [43, 1]);
+ #redirectingFactoryMoreUnnamedOptional, [43, 1]);
Expect.equals(40, instanceMirror.reflectee.field);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryStringIntTypeParameters'), [43, 1]);
+ #redirectingFactoryStringIntTypeParameters, [43, 1]);
Expect.equals(42, instanceMirror.reflectee.field);
Expect.isTrue(instanceMirror.reflectee is Class<String, int>);
Expect.isFalse(instanceMirror.reflectee is Class<int, String>);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryStringTypeParameters'), [43, 1]);
+ #redirectingFactoryStringTypeParameters, [43, 1]);
Expect.equals(42, instanceMirror.reflectee.field);
Expect.isTrue(instanceMirror.reflectee is Class<String, int>);
Expect.isTrue(instanceMirror.reflectee is Class<String, String>);
@@ -89,34 +89,34 @@ main() {
if (isDart2js) return;
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryUnnamedOptional'), [43]);
+ #redirectingFactoryUnnamedOptional, [43]);
Expect.equals(1, instanceMirror.reflectee.field);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryNamedOptional'), [43]);
+ #redirectingFactoryNamedOptional, [43]);
Expect.equals(1, instanceMirror.reflectee.field);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryNamedOptional'),
+ #redirectingFactoryNamedOptional,
[43],
- new Map()..[const Symbol('b')] = 1);
+ new Map()..[#b] = 1);
Expect.equals(42, instanceMirror.reflectee.field);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryMoreNamedOptional'),
+ #redirectingFactoryMoreNamedOptional,
[43],
- new Map()..[const Symbol('b')] = 1);
+ new Map()..[#b] = 1);
Expect.equals(40, instanceMirror.reflectee.field);
classMirror = reflect(new Class<String, int>(42)).type;
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryTypeParameters'), [43, 1]);
+ #redirectingFactoryTypeParameters, [43, 1]);
Expect.equals(42, instanceMirror.reflectee.field);
Expect.isTrue(instanceMirror.reflectee is Class<String, int>);
Expect.isFalse(instanceMirror.reflectee is Class<int, String>);
instanceMirror = classMirror.newInstance(
- const Symbol('redirectingFactoryReversedTypeParameters'), [43, 1]);
+ #redirectingFactoryReversedTypeParameters, [43, 1]);
Expect.equals(42, instanceMirror.reflectee.field);
Expect.isTrue(instanceMirror.reflectee is Class<int, String>);
Expect.isFalse(instanceMirror.reflectee is Class<String, int>);

Powered by Google App Engine
This is Rietveld 408576698