Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tests/lib/mirrors/parameter_metadata_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/mirrors/parameter_metadata_test.dart
diff --git a/tests/lib/mirrors/parameter_metadata_test.dart b/tests/lib/mirrors/parameter_metadata_test.dart
index 987e0590d4e8e946bcadb05234cac7e85c547a51..f27a149dce1ff2c0ba58f332b364ac1381b84ac8 100644
--- a/tests/lib/mirrors/parameter_metadata_test.dart
+++ b/tests/lib/mirrors/parameter_metadata_test.dart
@@ -9,7 +9,7 @@ import 'dart:mirrors';
import 'metadata_test.dart';
const m1 = 'm1';
-const m2 = const Symbol('m2');
+const m2 = #m2;
const m3 = const CustomAnnotation(3);
class CustomAnnotation {
@@ -33,23 +33,23 @@ class B {
main() {
ClassMirror cm = reflectClass(B);
- checkMetadata(cm.constructors[const Symbol('B.foo')].parameters[0], []);
+ checkMetadata(cm.constructors[#B.foo].parameters[0], []);
- checkMetadata(cm.constructors[const Symbol('B.bar')].parameters[0], [m3, m2]);
- checkMetadata(cm.constructors[const Symbol('B.bar')].parameters[1], []);
+ checkMetadata(cm.constructors[#B.bar].parameters[0], [m3, m2]);
+ checkMetadata(cm.constructors[#B.bar].parameters[1], []);
- checkMetadata(cm.members[const Symbol('baz')].parameters[0], [m1]);
- checkMetadata(cm.members[const Symbol('baz')].parameters[1], [m2]);
- checkMetadata(cm.members[const Symbol('baz')].parameters[2], [m3]);
+ checkMetadata(cm.members[#baz].parameters[0], [m1]);
+ checkMetadata(cm.members[#baz].parameters[1], [m2]);
+ checkMetadata(cm.members[#baz].parameters[2], [m3]);
- checkMetadata(cm.members[const Symbol('qux')].parameters[0], []);
- checkMetadata(cm.members[const Symbol('qux')].parameters[1], [m3, m2, m1]);
+ checkMetadata(cm.members[#qux].parameters[0], []);
+ checkMetadata(cm.members[#qux].parameters[1], [m3, m2, m1]);
- checkMetadata(cm.members[const Symbol('quux')].parameters[0], []);
- checkMetadata(cm.members[const Symbol('quux')].parameters[1], []);
+ checkMetadata(cm.members[#quux].parameters[0], []);
+ checkMetadata(cm.members[#quux].parameters[1], []);
- checkMetadata(cm.members[const Symbol('corge')].parameters[0], [m1]);
- checkMetadata(cm.members[const Symbol('corge')].parameters[1], [m2]);
+ checkMetadata(cm.members[#corge].parameters[0], [m1]);
+ checkMetadata(cm.members[#corge].parameters[1], [m2]);
checkMetadata(cm.members[const Symbol('x=')].parameters[0], [m2]);
}

Powered by Google App Engine
This is Rietveld 408576698