Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: tests/lib/mirrors/method_mirror_returntype_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/mirrors/method_mirror_returntype_test.dart
diff --git a/tests/lib/mirrors/method_mirror_returntype_test.dart b/tests/lib/mirrors/method_mirror_returntype_test.dart
index 5d13ece75c27e1d74c92ed57aed9d9a26d6bd2ec..cd525bb174a07293760e178b1c88f9fd5abd19f6 100644
--- a/tests/lib/mirrors/method_mirror_returntype_test.dart
+++ b/tests/lib/mirrors/method_mirror_returntype_test.dart
@@ -23,27 +23,27 @@ main() {
mm = reflect(intFunc).function;
Expect.equals(true, mm.returnType is TypeMirror);
- Expect.equals(const Symbol("int"), mm.returnType.simpleName);
+ Expect.equals(#int, mm.returnType.simpleName);
Expect.equals(true, mm.returnType.owner is LibraryMirror);
mm = reflect(dynamicFunc1).function;
Expect.equals(true, mm.returnType is TypeMirror);
- Expect.equals(const Symbol("dynamic"), mm.returnType.simpleName);
+ Expect.equals(#dynamic, mm.returnType.simpleName);
mm = reflect(dynamicFunc2).function;
Expect.equals(true, mm.returnType is TypeMirror);
- Expect.equals(const Symbol("dynamic"), mm.returnType.simpleName);
+ Expect.equals(#dynamic, mm.returnType.simpleName);
mm = reflect(voidFunc).function;
Expect.equals(true, mm.returnType is TypeMirror);
Expect.equals(const Symbol("void"), mm.returnType.simpleName);
ClassMirror cm = reflectClass(C);
- mm = cm.members[const Symbol("getE")];
+ mm = cm.members[#getE];
Expect.equals(true, mm.returnType is TypeMirror);
// The spec for this is ambigious and needs to be updated before it is clear
// what has to be returned.
//Expect.equals("E", _n(mm.returnType.simpleName));
Expect.equals(true, mm.owner is ClassMirror);
- Expect.equals(const Symbol("C"), mm.owner.simpleName);
+ Expect.equals(#C, mm.owner.simpleName);
}

Powered by Google App Engine
This is Rietveld 408576698