tests/lib/mirrors/metadata_constructed_constant_test.dart - Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/mirrors/metadata_constructed_constant_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/lib/mirrors/metadata_constructed_constant_test.dart

diff --git a/tests/lib/mirrors/metadata_constructed_constant_test.dart b/tests/lib/mirrors/metadata_constructed_constant_test.dart

index df74ff18bbfbc8efbf317c27de7d8138e54f5139..0d5e01e709132d955da312a77b86958eb445995d 100644

--- a/tests/lib/mirrors/metadata_constructed_constant_test.dart

+++ b/tests/lib/mirrors/metadata_constructed_constant_test.dart

@@ -21,6 +21,6 @@ class Foo {

main() {

var value =

- reflectClass(Foo).methods[const Symbol("m")].metadata.single.reflectee;

+ reflectClass(Foo).methods[#m].metadata.single.reflectee;

Expect.stringEquals('ConstructedConstant($StateError)', '$value');

}

« no previous file with comments | « tests/lib/mirrors/library_metadata_test.dart ('k') | tests/lib/mirrors/metadata_test.dart » ('j') | tests/lib/mirrors/parameter_test.dart » ('J')