Issue 24239006: cc: Don't discard framebuffer when using partial swaps

Issue 24239006: cc: Don't discard framebuffer when using partial swaps (Closed)

Created:
7 years, 3 months ago by piman

Modified:
7 years, 3 months ago

Reviewers:
danakj, Sami

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Don't discard framebuffer when using partial swaps BUG=294433 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224318

Patch Set 4 : rename, rebase fix, format #

Patch Set 5 : fix test #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -40 lines)			Patch
M	cc/debug/test_web_graphics_context_3d.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/output/direct_renderer.h	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	cc/output/direct_renderer.cc	View	1 2 3	1 chunk	+18 lines, -3 lines	0 comments	Download
M	cc/output/gl_renderer.h	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	cc/output/gl_renderer.cc	View	1 2 3	1 chunk	+17 lines, -13 lines	0 comments	Download
M	cc/output/gl_renderer_unittest.cc	View	1 2 3 4	8 chunks	+184 lines, -20 lines	0 comments	Download
M	cc/output/software_renderer.h	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	cc/output/software_renderer.cc	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

danakj

LGTM https://codereview.chromium.org/24239006/diff/11001/cc/output/direct_renderer.cc File cc/output/direct_renderer.cc (right): https://codereview.chromium.org/24239006/diff/11001/cc/output/direct_renderer.cc#newcode336 cc/output/direct_renderer.cc:336: bool redraw_rect_covers_full_surface = true; ok cool.. don't hate ...

7 years, 3 months ago (2013-09-20 00:41:46 UTC) #2

piman

https://codereview.chromium.org/24239006/diff/11001/cc/output/direct_renderer.cc File cc/output/direct_renderer.cc (right): https://codereview.chromium.org/24239006/diff/11001/cc/output/direct_renderer.cc#newcode336 cc/output/direct_renderer.cc:336: bool redraw_rect_covers_full_surface = true; On 2013/09/20 00:41:46, danakj wrote: ...

7 years, 3 months ago (2013-09-20 00:51:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/24239006/17001

7 years, 3 months ago (2013-09-20 00:54:33 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=169964

7 years, 3 months ago (2013-09-20 01:35:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/24239006/38001

7 years, 3 months ago (2013-09-20 03:12:50 UTC) #6

Message was sent while issue was closed.

Change committed as 224318

Expand Messages | Collapse Messages