Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2516)

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

Issue 2423883005: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/android (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/data_use_tab_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc b/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
index 7c095e45bd0595242347155bbf82fe527b65f392..6ef0c2db08084e8ab4c5802f3d4ec087d45b0cb8 100644
--- a/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
+++ b/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
@@ -123,8 +123,8 @@ void PartnerBookmarksShim::RenameBookmark(const BookmarkNode* node,
const NodeRenamingMapKey key(node->url(), node->GetTitle());
node_rename_remove_map_[key] = title;
SaveNodeMapping();
- FOR_EACH_OBSERVER(PartnerBookmarksShim::Observer, observers_,
- PartnerShimChanged(this));
+ for (PartnerBookmarksShim::Observer& observer : observers_)
Bernhard Bauer 2016/10/19 11:42:51 I think you could just use Observer (you're inside
+ observer.PartnerShimChanged(this);
}
void PartnerBookmarksShim::AddObserver(
@@ -180,8 +180,8 @@ void PartnerBookmarksShim::SetPartnerBookmarksRoot(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
g_partner_model_keeper.Get().partner_bookmarks_root = std::move(root_node);
g_partner_model_keeper.Get().loaded = true;
- FOR_EACH_OBSERVER(PartnerBookmarksShim::Observer, observers_,
- PartnerShimLoaded(this));
+ for (PartnerBookmarksShim::Observer& observer : observers_)
+ observer.PartnerShimLoaded(this);
}
PartnerBookmarksShim::NodeRenamingMapKey::NodeRenamingMapKey(
@@ -221,8 +221,8 @@ PartnerBookmarksShim::PartnerBookmarksShim(PrefService* prefs)
}
PartnerBookmarksShim::~PartnerBookmarksShim() {
- FOR_EACH_OBSERVER(PartnerBookmarksShim::Observer, observers_,
- ShimBeingDeleted(this));
+ for (PartnerBookmarksShim::Observer& observer : observers_)
+ observer.ShimBeingDeleted(this);
}
const BookmarkNode* PartnerBookmarksShim::GetNodeByID(
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/data_use_tab_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698