Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2423233002: Preserving extra http request headers in OpenURL navigation path [relanding]. (Closed)

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
Charlie Reis, nasko, mmenke
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, creis+watch_chromium.org, tburkard+watch_chromium.org, nasko+codewatch_chromium.org, jam, gavinp+prer_chromium.org, darin-cc_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preserving extra http request headers in OpenURL navigation path [relanding]. This CL makes sure that extra http request headers (e.g. in case of HTTP POST, the Content-Type: multipart/form-data; boundary=... header) are preserved when navigation uses the "OpenURL" code path. BUG=648648 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=creis@chromium.org,nasko@chromium.org,mmenke@chromium.org Committed: https://crrev.com/4a07d3a40109a3badac5463e780f7402d167dc30 Cr-Commit-Position: refs/heads/master@{#426281}

Patch Set 1 : This patchset is copied from https://crrev.com/2355023002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -34 lines) Patch
M chrome/browser/prerender/prerender_manager.cc View 4 chunks +25 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +12 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 6 chunks +7 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html View 2 chunks +14 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Łukasz Anforowicz
Hello. I am TBR-ing this CL, because this is just relanding unchanged https://crrev.com/2355023002 (which you ...
4 years, 2 months ago (2016-10-19 15:52:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423233002/1
4 years, 2 months ago (2016-10-19 17:00:21 UTC) #6
mmenke
On 2016/10/19 17:00:21, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-10-19 17:08:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164057)
4 years, 2 months ago (2016-10-19 19:17:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423233002/1
4 years, 2 months ago (2016-10-19 19:58:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 21:03:48 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 13:11:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a07d3a40109a3badac5463e780f7402d167dc30
Cr-Commit-Position: refs/heads/master@{#426281}

Powered by Google App Engine
This is Rietveld 408576698