third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html - Issue 2423233002: Preserving extra http request headers in OpenURL navigation path [relanding].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html

Issue 2423233002: Preserving extra http request headers in OpenURL navigation path [relanding]. (Closed)

Patch Set: This patchset is copied from https://crrev.com/2355023002 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_frame_proxy.cc ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-no-referrer.html b/third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html

similarity index 65%

copy from third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-no-referrer.html

copy to third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html

index d564b68b5074be3d2738d8e73f7c4a9ade490601..411f54e936fd69140aac8bba95c52816528540b3 100644

--- a/third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-no-referrer.html

+++ b/third_party/WebKit/LayoutTests/http/tests/navigation/form-with-enctype-targets-cross-site-frame.html

@@ -1,17 +1,26 @@

<!DOCTYPE html>

<!--

-The test verifies that a form with target="crossSiteFrame" works fine

+The test verifies that a form with target="crossSiteFrame" and

+with enctype="multipart/form-data" works fine

(especially in presence of out-of-process-iframes, aka OOPIFs, aka

blink::RemoteFrames which are present in --site-per-process mode).

The test finishes successfully, if form-target.pl ends up calling

testRunner.notifyDone() after main frame calls testRuner.waitUntilDone

and submits the form. Expected test output helps verify that the

-correct HTTP method was used and that test field's value from the form

-was propagated correctly.

+correct HTTP headers were sent together with the HTTP POST request.

+In particular, if wrong Content-Type header is send with the HTTP request,

+then the field value will be garbled:

+- Expected:

+ test-field = test-value

+- Actual if no Content-Type is sent:

+ ------WebKitFormBoundaryxVEhq0cRaPT6heQg Content-Disposition: form-data =

+ name = "test-field" test-value ------WebKitFormBoundaryxVEhq0cRaPT6heQg--

-->

<html>

-<meta name="referrer" content="no-referrer">

if (window.testRunner) {

testRunner.dumpAsText();

@@ -27,6 +36,7 @@ was propagated correctly.

<form

method="POST"

+ enctype="multipart/form-data"

action="http://localhost:8080/navigation/resources/form-target.pl"

target="cross-site-frame">

Test field: