DevTools: popovers use padding instead of margin

DevTools: popovers use padding instead of margin

The root cause of this issue is crbug.com/633602, which leads to cases when
scrollbars are not removed from elements even though the content would fit. In
our case, popovers with only one line of content will exhibit a scrollbar on
certain zoom levels before we apply their correct width/height.

By using padding instead of margins, the inner content has extra height and no
scrollbar, even before its fixed width/height is applied.

BUG=599214
Committed: https://crrev.com/35a2db47116994f527950d9bac81873a9661c096
Cr-Commit-Position: refs/heads/master@{#426348}

[luoe, 2016-10-17 22:34:18]

Description was changed from

==========
DevTools: popovers use padding instead of margin

BUG=599214
==========

to

==========
DevTools: popovers use padding instead of margin

The root cause of this issue is crbug.com/633602, which leads to cases when
scrollbars are not removed from elements even though the content would fit. In
our case, popovers with only one line of content will exhibit a scrollbar on
certain zoom levels before we apply their correct width/height.

By using padding instead of margins, the inner content has extra height and no
scrollbar, even before its fixed width/height is applied.

BUG=599214
==========

[luoe, 2016-10-17 22:35:11]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[luoe, 2016-10-17 22:35:23]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[commit-bot: I haz the power, 2016-10-17 22:35:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 00:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:10:51]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-10-18 22:23:10]

lgtm, thanks!

[luoe, 2016-10-19 00:22:29]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:23:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 01:35:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 01:35:06]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[luoe, 2016-10-19 21:32:43]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 23:59:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:59:18]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-10-20 00:00:11]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-10-20 00:00:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 00:19:19]

Description was changed from

==========
DevTools: popovers use padding instead of margin

The root cause of this issue is crbug.com/633602, which leads to cases when
scrollbars are not removed from elements even though the content would fit. In
our case, popovers with only one line of content will exhibit a scrollbar on
certain zoom levels before we apply their correct width/height.

By using padding instead of margins, the inner content has extra height and no
scrollbar, even before its fixed width/height is applied.

BUG=599214
==========

to

==========
DevTools: popovers use padding instead of margin

The root cause of this issue is crbug.com/633602, which leads to cases when
scrollbars are not removed from elements even though the content would fit. In
our case, popovers with only one line of content will exhibit a scrollbar on
certain zoom levels before we apply their correct width/height.

By using padding instead of margins, the inner content has extra height and no
scrollbar, even before its fixed width/height is applied.

BUG=599214
==========

[commit-bot: I haz the power, 2016-10-20 00:19:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:13:42]

Description was changed from

==========
DevTools: popovers use padding instead of margin

The root cause of this issue is crbug.com/633602, which leads to cases when
scrollbars are not removed from elements even though the content would fit. In
our case, popovers with only one line of content will exhibit a scrollbar on
certain zoom levels before we apply their correct width/height.

By using padding instead of margins, the inner content has extra height and no
scrollbar, even before its fixed width/height is applied.

BUG=599214
==========

to

==========
DevTools: popovers use padding instead of margin

The root cause of this issue is crbug.com/633602, which leads to cases when
scrollbars are not removed from elements even though the content would fit. In
our case, popovers with only one line of content will exhibit a scrollbar on
certain zoom levels before we apply their correct width/height.

By using padding instead of margins, the inner content has extra height and no
scrollbar, even before its fixed width/height is applied.

BUG=599214

Committed: https://crrev.com/35a2db47116994f527950d9bac81873a9661c096
Cr-Commit-Position: refs/heads/master@{#426348}
==========

[commit-bot: I haz the power, 2016-10-21 13:13:44]

Patchset 1 (id:??) landed as
https://crrev.com/35a2db47116994f527950d9bac81873a9661c096
Cr-Commit-Position: refs/heads/master@{#426348}