Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Issue 2422413002: DevTools: popovers use padding instead of margin (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
index c17ef693ca9fd348085efafcf871bd880e1ae049..1880a3f26ff6b8679caa4591935b0bae1def7563 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
@@ -147,12 +147,12 @@ WebInspector.Popover.prototype = {
},
/**
- * @param {boolean} noMargins
+ * @param {boolean} noPadding
*/
- setNoMargins: function(noMargins)
+ setNoPadding: function(noPadding)
{
- this._hasNoMargins = noMargins;
- this._contentDiv.classList.toggle("no-margin", this._hasNoMargins);
+ this._hasNoPadding = noPadding;
+ this._contentDiv.classList.toggle("no-padding", this._hasNoPadding);
},
/**
@@ -163,9 +163,9 @@ WebInspector.Popover.prototype = {
*/
positionElement: function(anchorElement, preferredWidth, preferredHeight, arrowDirection)
{
- const borderWidth = this._hasNoMargins ? 0 : 8;
+ const borderWidth = this._hasNoPadding ? 0 : 8;
const scrollerWidth = this._hasFixedHeight ? 0 : 14;
- const arrowHeight = this._hasNoMargins ? 8 : 15;
+ const arrowHeight = this._hasNoPadding ? 8 : 15;
const arrowOffset = 10;
const borderRadius = 4;
const arrowRadius = 6;

Powered by Google App Engine
This is Rietveld 408576698