Source/bindings/tests/results/V8TestExtendedEvent.cpp - Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestExtendedEvent.cpp

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaseline Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestExtendedEvent.cpp

diff --git a/Source/bindings/tests/results/V8TestExtendedEvent.cpp b/Source/bindings/tests/results/V8TestExtendedEvent.cpp

index 790f02430098aa74f2173a74706398d25792653e..24e208f0992f2137722c97578eb6d23a562f6007 100644

--- a/Source/bindings/tests/results/V8TestExtendedEvent.cpp

+++ b/Source/bindings/tests/results/V8TestExtendedEvent.cpp

@@ -25,6 +25,7 @@

#include "RuntimeEnabledFeatures.h"

#include "V8TestEvent.h"

#include "bindings/v8/Dictionary.h"

+#include "bindings/v8/ExceptionMessages.h"

#include "bindings/v8/ScriptController.h"

#include "bindings/v8/V8Binding.h"

#include "bindings/v8/V8DOMConfiguration.h"

@@ -97,7 +98,7 @@ static void keyLocationAttributeGetterCallback(v8::Local<v8::String> name, const

static void constructor(const v8::FunctionCallbackInfo<v8::Value>& args)

{

if (args.Length() < 1) {

- throwNotEnoughArgumentsError(args.GetIsolate());

+ throwTypeError(ExceptionMessages::failedToConstruct("Event", "An event name must be provided."), args.GetIsolate());

return;

}