Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: Source/bindings/tests/results/V8TestActiveDOMObject.cpp

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestActiveDOMObject.cpp
diff --git a/Source/bindings/tests/results/V8TestActiveDOMObject.cpp b/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
index fbfc54207d6a8157d69a06553f59fff771dc2a15..4561fc3778dcb981be21fb1c35e61da5ed23fca0 100644
--- a/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
+++ b/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
@@ -24,6 +24,7 @@
#include "RuntimeEnabledFeatures.h"
#include "V8Node.h"
#include "bindings/v8/BindingSecurity.h"
+#include "bindings/v8/ExceptionMessages.h"
#include "bindings/v8/ExceptionState.h"
#include "bindings/v8/ScriptController.h"
#include "bindings/v8/V8Binding.h"
@@ -91,7 +92,7 @@ bool namedSecurityCheck(v8::Local<v8::Object> host, v8::Local<v8::Value> key, v8
static void excitingFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>& args)
{
if (UNLIKELY(args.Length() < 1)) {
- throwNotEnoughArgumentsError(args.GetIsolate());
+ throwTypeError(ExceptionMessages::failedToExecute("excitingFunction", "TestActiveDOMObject", ExceptionMessages::notEnoughArguments(1, args.Length())), args.GetIsolate());
return;
}
TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(args.Holder());
@@ -113,7 +114,7 @@ static void excitingFunctionMethodCallback(const v8::FunctionCallbackInfo<v8::Va
static void postMessageMethod(const v8::FunctionCallbackInfo<v8::Value>& args)
{
if (UNLIKELY(args.Length() < 1)) {
- throwNotEnoughArgumentsError(args.GetIsolate());
+ throwTypeError(ExceptionMessages::failedToExecute("postMessage", "TestActiveDOMObject", ExceptionMessages::notEnoughArguments(1, args.Length())), args.GetIsolate());
return;
}
TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(args.Holder());
« no previous file with comments | « Source/bindings/tests/results/V8Float64Array.cpp ('k') | Source/bindings/tests/results/V8TestCustomAccessors.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698